packages/chronicle/src/lib/tree-utils.test.ts (2)

85-113: ⚡ Quick win

Add a regression test for index_page on non-root slugs.

Please add a case asserting that index_page does not override folder/non-root redirects (or 404 paths).

💡 Proposed test case

 describe('resolveDocsRedirect', () => {
@@
   test('index_page takes priority over first page', () => {
     expect(resolveDocsRedirect(['docs'], tree, { dir: 'docs', index_page: 'custom' }))
       .toBe('/docs/custom')
   })
+
+  test('does not apply index_page for nested slugs', () => {
+    expect(resolveDocsRedirect(['docs', 'guides'], tree, { dir: 'docs', index_page: 'custom' }))
+      .toBe('/docs/guides/install')
+  })
 })

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/chronicle/src/lib/tree-utils.test.ts` around lines 85 - 113, Add a
regression test in tree-utils.test.ts for resolveDocsRedirect to ensure
index_page only applies to the content root: call resolveDocsRedirect with a
non-root slug (e.g., ['docs', 'guides']) and content config that contains dir:
'docs' plus index_page: 'custom' and assert it still redirects to the folder's
first child (e.g., '/docs/guides/install') rather than '/docs/custom'; use the
existing test pattern and the same tree fixture so the test name and
expectations match the other cases.

---

3-3: ⚡ Quick win

Use project path alias instead of relative import.

Switch this test import to @/lib/tree-utils for consistency with the repo alias policy.

💡 Proposed fix

-import { getFirstPageUrl, findFolderFirstPage, resolveDocsRedirect } from './tree-utils'
+import { getFirstPageUrl, findFolderFirstPage, resolveDocsRedirect } from '@/lib/tree-utils'

As per coding guidelines **/*.{ts,tsx}: Use path alias @/* → ./src/* configured in tsconfig and vite.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/chronicle/src/lib/tree-utils.test.ts` at line 3, Update the test
import to use the project path alias: replace the relative import of the module
used by tests (import { getFirstPageUrl, findFolderFirstPage,
resolveDocsRedirect } from './tree-utils') with the aliased path import from
'@/lib/tree-utils' so the tests follow the repo's tsconfig/vite alias policy and
resolve the same exported symbols (getFirstPageUrl, findFolderFirstPage,
resolveDocsRedirect).

packages/chronicle/src/server/entry-server.tsx (1)

47-57: ⚡ Quick win

Move API index redirect before page-tree fetch.

For RouteType.ApiIndex, lines [47-50] still load docs tree/page before returning the 307. Reordering this keeps the redirect path truly early-exit and reduces SSR work.

💡 Suggested structure

-    const [tree, page] = await Promise.all([
-      getPageTree(),
-      route.type === RouteType.DocsPage ? getPage(route.slug) : Promise.resolve(null),
-    ]);
-    // SSR redirects for index pages
     if (route.type === RouteType.ApiIndex) {
       const firstUrl = getFirstApiUrl(apiSpecs);
       if (firstUrl) {
         return new Response(null, { status: StatusCodes.TEMPORARY_REDIRECT, headers: { Location: firstUrl } });
       }
     }
+
+    const [tree, page] = await Promise.all([
+      getPageTree(),
+      route.type === RouteType.DocsPage ? getPage(route.slug) : Promise.resolve(null),
+    ]);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/chronicle/src/server/entry-server.tsx` around lines 47 - 57, The API
index redirect runs after expensive page-tree/page fetches; move the
RouteType.ApiIndex early-exit before calling getPageTree() and getPage() so SSR
work is avoided when redirecting. Specifically, check if route.type ===
RouteType.ApiIndex, call getFirstApiUrl(apiSpecs) and return the
TEMPORARY_REDIRECT response immediately if a URL exists, and only then perform
the Promise.all([getPageTree(), ...]) calls for non-ApiIndex routes (functions:
getPageTree, getPage, getFirstApiUrl; symbol: RouteType.ApiIndex).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes